فهرست منبع

Updated status on a tracked issue

arianagiroux 1 هفته پیش
والد
کامیت
fa22bf25f2

+ 20 - 0
issues/bug:-create-in-collection-doesnt-render/description

@@ -1 +1,21 @@
+The "createInCollection" widget doesn't render keypresses on every press
+
+--- @0.0.8
+For some reason, I'm not entirely sure why, the widget doesn't get every update when keys are pressed. I think it has something to do with the update function specific to the widget, as the bug seems localized to just this widget.
+
+The bug can be recreated by trying to enter any text (especially noticeable upon backspace) after pressing "c" in the collection view.
+
+--- @0.0.8
+Upon some further investigation, it doesn't seem to be the update func? Is there some delay between the render and update cycle? It feels like its coming in a string -> content cycle too late?
+
+It might be worthwhile stepping back through history to find exactly *when* the bug was introduced. I think it might be related to the viewport specifically?
+
+--- @0.0.8
+Upon further reflection, is the widget not somehow like... "embedded" in the collection browser?
+
+--- @86eb3fe
+I'm not entirely sure what was wrong with the "createInCollection" widget, but I've reimplemented it as "setTitle". I *think* it might have had to do with dispatching a render cmd before the update cmd.
+
+Ultimately, this change is pretty much just a refactor and renaming of the existing "createInCollection" widget - so I see no reason not to push the changes.
+
 

+ 1 - 1
issues/bug:-create-in-collection-doesnt-render/status

@@ -1 +1 @@
-open
+patched

+ 0 - 0
issues/bug:-create-in-collection-doesnt-render/tags/patched